[react] Updates to View Transition - #72339
Conversation
|
|
||
| declare module "react" { | ||
| interface ViewTransitionInstance { | ||
| getComputedStyle: () => CSSStyleDeclaration; |
There was a problem hiding this comment.
This is wrong. This is on each Animatable below.
It's more like an interface that extends implements Animatable. Kind of like an Element, a PsuedoElement if you will.
There was a problem hiding this comment.
34d56f3 to
dad3d85
Compare
|
@eps1lon Thank you for submitting this PR! This is a live comment that I will keep updated. 2 packages in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 72339,
"author": "eps1lon",
"headCommitOid": "dad3d859a49490ac8fbd67f60055ec0b6cbdd66b",
"mergeBaseOid": "5d7e8c0570c4c64da0133593c0e83edbce4a1b98",
"lastPushDate": "2025-04-01T15:25:34.000Z",
"lastActivityDate": "2025-04-01T18:35:49.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react-dom",
"kind": "edit",
"files": [
{
"path": "types/react-dom/experimental.d.ts",
"kind": "definition"
},
{
"path": "types/react-dom/test/experimental-tests.tsx",
"kind": "test"
}
],
"owners": [
"MartynasZilinskas",
"theruther4d",
"Jessidhia",
"eps1lon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "react",
"kind": "edit",
"files": [
{
"path": "types/react/experimental.d.ts",
"kind": "definition"
},
{
"path": "types/react/test/experimental.tsx",
"kind": "test"
},
{
"path": "types/react/ts5.0/experimental.d.ts",
"kind": "definition"
},
{
"path": "types/react/ts5.0/test/experimental.tsx",
"kind": "test"
}
],
"owners": [
"johnnyreilly",
"bbenezech",
"pzavolinsky",
"ericanderson",
"DovydasNavickas",
"theruther4d",
"guilhermehubner",
"ferdaber",
"jrakotoharisoa",
"pascaloliv",
"hotell",
"franklixuefei",
"Jessidhia",
"saranshkataria",
"lukyth",
"eps1lon",
"zieka",
"dancerphil",
"dimitropoulos",
"disjukr",
"vhfmag",
"priyanshurav",
"Semigradsky",
"mattpocock"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sebmarkbage",
"date": "2025-04-01T18:35:49.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2770385389,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/dad3d859a49490ac8fbd67f60055ec0b6cbdd66b/checks?check_suite_id=36539648299"
} |
|
🔔 @MartynasZilinskas @theruther4d @Jessidhia @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @saranshkataria @lukyth @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @priyanshurav @Semigradsky @mattpocock — please review this PR in the next few days. Be sure to explicitly select |
|
@eps1lon The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
|
Failures are unrelated |
Types for: