node: add missing Transformer.cancel method #73140
Conversation
|
@hexchain Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 73140,
"author": "hexchain",
"headCommitOid": "c943cdcc73f86f067410b5068d0882edf27e0489",
"mergeBaseOid": "52fad74bc7bf4d1155f98929ee92a70b28e2a72e",
"lastPushDate": "2025-06-28T17:16:32.000Z",
"lastActivityDate": "2025-06-30T11:17:55.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/stream/web.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/stream.ts",
"kind": "test"
},
{
"path": "types/node/v22/stream/web.d.ts",
"kind": "definition"
},
{
"path": "types/node/v22/test/stream.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky",
"Renegade334",
"anonrig"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "anonrig",
"date": "2025-06-30T11:17:55.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "Renegade334",
"date": "2025-06-30T06:33:26.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 3015820701,
"ciResult": "pass"
} |
|
🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky @Renegade334 @anonrig — please review this PR in the next few days. Be sure to explicitly select |
Renegade334
left a comment
There was a problem hiding this comment.
Could you add a test example under test/web.ts?
DefinitelyTyped/types/node/test/stream.ts
Lines 754 to 758 in 52fad74
Looks good otherwise.
02acbb0 to
0848422
Compare
|
Done. I updated the existing test to reflect the change in this PR. |
|
@Renegade334 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
0848422 to
c943cdc
Compare
|
Formatting fixed. |
|
@Renegade334 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.