[office-js, office-js-preview] Add strong typing to the Office.AsyncResult.value property #74271
Conversation
|
@AlexJerabek Thank you for submitting this PR! This is a live comment that I will keep updated. 2 packages in this PR
Code ReviewsBecause this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74271,
"author": "AlexJerabek",
"headCommitOid": "a1c29ad17c43ef775ee3c59078cd65da14026467",
"mergeBaseOid": "86aac7d1dff96c49da8d03ae9e400f39b7e86cae",
"lastPushDate": "2025-12-26T21:16:17.000Z",
"lastActivityDate": "2025-12-26T21:16:17.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "office-js-preview",
"kind": "edit",
"files": [
{
"path": "types/office-js-preview/index.d.ts",
"kind": "definition"
}
],
"owners": [
"OfficeDev",
"Rick-Kirkham",
"AlexJerabek",
"ElizabethSamuel-MSFT",
"alison-mk",
"samantharamon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "office-js",
"kind": "edit",
"files": [
{
"path": "types/office-js/index.d.ts",
"kind": "definition"
}
],
"owners": [
"OfficeDev",
"Rick-Kirkham",
"AlexJerabek",
"ElizabethSamuel-MSFT",
"alison-mk",
"samantharamon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [],
"mainBotCommentID": 3693375833,
"ciResult": "pass"
} |
|
Hey @AlexJerabek, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @OfficeDev @Rick-Kirkham @ElizabethSamuel-MSFT @alison-mk @samantharamon — please review this PR in the next few days. Be sure to explicitly select |
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
valuereturned bygetSelectedDataAsyncOfficeDev/office-js-docs-reference#1048 (comment)package.json.