Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Actual default conductance distribution method of iMOD5 is missing #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoerivanEngelen opened this issue Jan 28, 2025 · 0 comments · Fixed by #1394
Closed

Actual default conductance distribution method of iMOD5 is missing #1391

JoerivanEngelen opened this issue Jan 28, 2025 · 0 comments · Fixed by #1394
Assignees
@JoerivanEngelen
Milestone
v1.0 release

Comments

@JoerivanEngelen
Copy link
Contributor

JoerivanEngelen commented Jan 28, 2025 •
edited
Loading

I just noticed that we missed a DISTRIBUTING_OPTION.by_corrected_thickness option.
I either overlooked this one, I thought this was an unimportant setting, or it has been added in iMOD 5.6.

Normally I wouldn't be bothered too much by this, but unfortunately this is the default distribution setting for Rivers (at least for iMOD 5.6), contrary to what is written in the manual. The manual states that DISTRCOND=0 distributes conductances by a corrected transmissivity, and DISTRCOND=-1 distributes by a corrected crosscut thickness, but it is the exact opposite.

Adding this is quite low-hanging fruit, as all functionality required is pretty much there already.
@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite Jan 28, 2025
@JoerivanEngelen JoerivanEngelen mentioned this issue Jan 28, 2025
Closed
@JoerivanEngelen JoerivanEngelen added this to the v1.0 release milestone Jan 28, 2025
@JoerivanEngelen JoerivanEngelen self-assigned this Jan 28, 2025
@JoerivanEngelen JoerivanEngelen moved this from 📯 New to 🏗 In Progress in iMOD Suite Jan 28, 2025
@JoerivanEngelen JoerivanEngelen mentioned this issue Jan 28, 2025
Merged
5 tasks
@JoerivanEngelen JoerivanEngelen moved this from 🏗 In Progress to 🧐 In Review in iMOD Suite Jan 28, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 31, 2025
@JoerivanEngelen
Issue #1391 add by corrected thickness (#1394)
4d40ead 
Fixes #1391 

# Description
- Add ``DISTRIBUTING_OPTION.by_corrected_thickness`` setting. 
- Move logic to compute correction factors into separate function.

# Checklist

- [x] Links to correct issue
- [x] Update changelog, if changes affect users
- [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [x] Unit tests were added
- [ ] **If feature added**: Added/extended example
@github-project-automation github-project-automation bot moved this from 🧐 In Review to ✅ Done in iMOD Suite Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoerivanEngelen JoerivanEngelen

Labels
None yet
Projects
iMOD Suite
Status: ✅ Done
Milestone
v1.0 release
Development

Successfully merging a pull request may close this issue.

Issue #1391 add by corrected thickness Deltares/imod-python
1 participant
@JoerivanEngelen