Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Bug] - Incorrect writing of MetaSWAP file with sprinkling capacities (scap_svat.inp) #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
verkaik opened this issue May 20, 2025 · 1 comment Β· Fixed by #1533
Closed

[Bug] - Incorrect writing of MetaSWAP file with sprinkling capacities (scap_svat.inp) #1532

verkaik opened this issue May 20, 2025 · 1 comment Β· Fixed by #1533
Assignees
Labels
bug Something isn't working

Comments

@verkaik
Copy link
Contributor

verkaik commented May 20, 2025

Bug description

  • MetaSWAP svats with surface water sprinkling activated do not seem to be written to scap_svat.inp
  • default values are written, e.g. as 0., but this likely to give issues with the MetaSWAP kernel that checks fixed-sized strings for not being empty to increase internal counters (not yet tested).

Steps to reproduce
Use a LHM iMOD project (.prj) file with irrigation data specified in the (CAP) section.

@JoerivanEngelen
Copy link
Contributor

I found the two culprits and opened up a PR. I'm not sure whether the first bullet point is really a problem. I talked to @HendrikKok (my MetaSWAP guru) and he saw no issues with the present approach.

Implementing what you propose would further complicate the code base, as suddenly the dtype of columns will not be consistent anymore. You can see in the PR. The extra amount of code is bearable, but I'm not happy that it affects so much files just for this case, and complicates logic. Some testing is required first, I think.

@JoerivanEngelen JoerivanEngelen self-assigned this May 21, 2025
@JoerivanEngelen JoerivanEngelen moved this from πŸ“― New to πŸ— In Progress in iMOD Suite May 21, 2025
@JoerivanEngelen JoerivanEngelen moved this from πŸ— In Progress to 🧐 In Review in iMOD Suite May 27, 2025
@github-project-automation github-project-automation bot moved this from 🧐 In Review to βœ… Done in iMOD Suite May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: βœ… Done
2 participants