Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Issue #1532 Write surface water sprinkling in absence of groundwater abstraction rates #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JoerivanEngelen
Copy link
Contributor

@JoerivanEngelen JoerivanEngelen commented May 20, 2025

Fixes #1532

Description

Fixes a bug where surface water rates were not written to file in absence of groundwater abstraction rates.

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example

@Huite
Copy link
Contributor

Huite commented May 20, 2025

Note that pandas has some NA support.

E.g. for the MODFLOW 6 input files which have an irregular number of columns (e.g. DISV), I use the pandas integer NA. https://pandas.pydata.org/docs/user_guide/integer_na.html

You might be able to use some comparable functionality. pandas.NA should maintain type.

@JoerivanEngelen JoerivanEngelen marked this pull request as ready for review May 27, 2025 09:09
Copy link

@JoerivanEngelen JoerivanEngelen changed the title Render inactive cells with rates as "" instead of 0.0 Issue #1532 Fix bug where surface water sprinkling not written in absence of groundwater abstraction rates May 27, 2025
@JoerivanEngelen
Copy link
Contributor Author

I refrained from adding the extra logic to "" marks instead of 0.0 in scap_svat, as @HendrikKok and I don't see any reason why MetaSWAP would fail when a 0.0 is written in scap_svat.inp instead of "".

@JoerivanEngelen JoerivanEngelen changed the title Issue #1532 Fix bug where surface water sprinkling not written in absence of groundwater abstraction rates Issue #1532 Write surface water sprinkling in absence of groundwater abstraction rates May 27, 2025
@JoerivanEngelen JoerivanEngelen merged commit c2703ec into master May 27, 2025
7 checks passed
@JoerivanEngelen JoerivanEngelen deleted the issue_#1532_incorrect_inactive_cell_writing_scap_svat branch May 27, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] - Incorrect writing of MetaSWAP file with sprinkling capacities (scap_svat.inp)
2 participants