Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add clipping method to MetaSwapModel #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Manangka opened this issue Dec 11, 2023 · 0 comments Β· Fixed by #1478
Closed

Add clipping method to MetaSwapModel #443

Manangka opened this issue Dec 11, 2023 · 0 comments Β· Fixed by #1478
Assignees

Comments

@Manangka
Copy link
Collaborator

Manangka commented Dec 11, 2023

In GitLab by @JoerivanEngelen on Jun 26, 2023, 11:23

Requirements:

  • Loop over list of packages which contain grid data
  • Clip these packages
  • No boundary conditions need to be set at the model edge, since MetaSWAP does not simulate lateral flow
@Manangka Manangka changed the title [PLACEHOLDER] - for issue #443 Add clipping method to MetaSwapModel Dec 12, 2023
@Manangka Manangka reopened this Dec 12, 2023
@github-project-automation github-project-automation bot moved this to πŸ“― New in iMOD Suite Mar 4, 2024
@JoerivanEngelen JoerivanEngelen moved this from πŸ“― New to 🀝 Accepted in iMOD Suite Mar 28, 2024
@JoerivanEngelen JoerivanEngelen moved this from 🀝 Accepted to 🧐 In Review in iMOD Suite Mar 7, 2025
@JoerivanEngelen JoerivanEngelen self-assigned this Mar 7, 2025
JoerivanEngelen added a commit that referenced this issue Mar 10, 2025
Fixes #443 and #364

# Description

* Adds clipping method to ``imod.msw.MetaSwapModel``, this includes a
special case for ``clip_box`` method of PrecipitationMapping, and
EvapotranspirationMapping: These should not be clipped if a
``MeteoGridCopy`` instance is part of the model. Otherwise nonsensical
mappings are generated.
* Add ``imod.msw.MetaSwapModel.clip_box`` method to public API
* Override ``clip_box`` method in MeteoMapping, should clip meteo
attribute instead of dataset attribute.
* Refactor: Move time slice clipping logic to
``imod.common.utilities.clip``.
* Refactor: Make ``meteo`` class variable an attribute. This makes more
sense. I think I made it a class variable before to please mypy.
* Boyscouting: Add some extra docstring information on usecase to
``imod.msw.MeteoGridCopy``

# Checklist
- [x] Links to correct issue
- [x] Update changelog, if changes affect users
- [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [x] Unit tests were added
- [ ] **If feature added**: Added/extended example
@github-project-automation github-project-automation bot moved this from 🧐 In Review to βœ… Done in iMOD Suite Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: βœ… Done
Development

Successfully merging a pull request may close this issue.

2 participants