Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Modflow 6: No unit tests for the DiscretizationVertices package #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Manangka opened this issue Jul 24, 2023 · 1 comment · Fixed by #1473
Closed

Modflow 6: No unit tests for the DiscretizationVertices package #483

Manangka opened this issue Jul 24, 2023 · 1 comment · Fixed by #1473
Labels
bug Something isn't working needs tests Needs unit tests

Comments

@Manangka
Copy link
Collaborator

In GitLab by @JoerivanEngelen on Jul 24, 2023, 17:49

We are currenlty lacking unit tests for the DiscretizationVertices package.

This already caused one bug, which most people didn't run into luckily. https://gitlab.com/deltares/imod/imod-python/-/issues/398
@Manangka
Copy link
Collaborator Author

In GitLab by @JoerivanEngelen on Jul 24, 2023, 17:50

marked this issue as related to #398

@JoerivanEngelen JoerivanEngelen moved this to 📯 New in iMOD Suite Dec 21, 2023
@JoerivanEngelen JoerivanEngelen moved this from 📯 New to 🤝 Accepted in iMOD Suite Dec 21, 2023
@JoerivanEngelen JoerivanEngelen added bug Something isn't working and removed type::bug labels Jan 16, 2024
@JoerivanEngelen JoerivanEngelen mentioned this issue Mar 5, 2025
Merged
5 tasks
JoerivanEngelen added a commit that referenced this issue Mar 5, 2025
@JoerivanEngelen
Issue #483 Add missing unittests for disv (#1473)
2709621 
Fixes #483

# Description
Adds relevant and adapted unittests from DIS package to unittest for
DISV package

# Checklist
- [x] Links to correct issue
- [ ] Update changelog, if changes affect users
- [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [x] Unit tests were added
- [ ] **If feature added**: Added/extended example
@github-project-automation github-project-automation bot moved this from 🤝 Accepted to ✅ Done in iMOD Suite Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs tests Needs unit tests
Projects
iMOD Suite
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #483 Add missing unittests for disv Deltares/imod-python
2 participants
@JoerivanEngelen @Manangka