Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make options like "save_flows" configurable for high level well packages #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Manangka opened this issue Nov 17, 2023 · 1 comment Β· Fixed by #916
Closed

Make options like "save_flows" configurable for high level well packages #652

Manangka opened this issue Nov 17, 2023 · 1 comment Β· Fixed by #916
Assignees
Labels

Comments

@Manangka
Copy link
Collaborator

In GitLab by @JoerivanEngelen on Nov 17, 2023, 14:44

Created from: https://gitlab.com/deltares/imod/imod-python/-/work_items/623

Currently unable to use options like save_flows. Therefore, save_flows was hardcoded in the jinja template in the featurebranch, which is unwanted.

The user should be able to pass settings for high-level packages.

@JoerivanEngelen
Copy link
Contributor

JoerivanEngelen commented Feb 28, 2024

Update: these settings are passed on to the Well package at the current state of the codebase, but not to the HorizontalFlowBarrier packages yet.

@luitjansl luitjansl moved this from 🀝 Accepted to πŸ— In Progress in iMOD Suite Mar 12, 2024
@luitjansl luitjansl self-assigned this Mar 12, 2024
@luitjansl luitjansl moved this from πŸ— In Progress to 🧐 In Review in iMOD Suite Mar 12, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 13, 2024
Fixes #652 

# Description
made several options configurable for the well package: "save flows",
"print input" and "print flows". these can now be set on the high level
well package, and they will then appear in the (low level) mf6 input.
 Added tests.
For the HFB package, there is only one such options: print input. A test
has been added to ensure it appear on the low-level object.

# Checklist

- [X] Links to correct issue
- [X] Update changelog, if changes affect users
- [X] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [X] Unit tests were added
- [ ] **If feature added**: Added/extended example
@github-project-automation github-project-automation bot moved this from 🧐 In Review to βœ… Done in iMOD Suite Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: βœ… Done
Development

Successfully merging a pull request may close this issue.

3 participants