Thanks to visit codestin.com
Credit goes to github.com

Skip to content

separate pipeline for modflow's nightly build ? #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
luitjansl opened this issue Jan 19, 2024 · 2 comments · Fixed by #777
Closed

separate pipeline for modflow's nightly build ? #757

luitjansl opened this issue Jan 19, 2024 · 2 comments · Fixed by #777
Assignees
@Manangka
Labels
discussion Discussion about design or other decisions
Milestone
Epic: Build impro...

Comments

@luitjansl
Copy link
Contributor

luitjansl commented Jan 19, 2024 •
edited
Loading

sometimes we are interested in using features or fixes only present in the nightly build of MF6 (for example to obtain correct CHD fluxes at partition boundaries).
We should be able to use it for testing purposes in the pipeline, but currently some transport tests fail with it.

We should address this, and in such a manner that we don't loose support for the last stable release. Perhaps a separate pipeline for each MF6 version?
@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite Jan 19, 2024
@luitjansl luitjansl changed the title include modflow's nightly build in pipeline separate pipeline for modflow's nightly build ? Jan 19, 2024
@JoerivanEngelen JoerivanEngelen added the discussion Discussion about design or other decisions label Jan 19, 2024
@JoerivanEngelen
Copy link
Contributor

Blocked by #748

@JoerivanEngelen JoerivanEngelen moved this from 📯 New to 🤝 Accepted in iMOD Suite Jan 22, 2024
@JoerivanEngelen
Copy link
Contributor

As discussed with @luitjansl and @Manangka, we prefer the following solution:

  • We can keep the build pipeline that is triggered by PRs the same
  • Separate nightly build against nightly MODFLOW 6 build on TeamCity
  • If nightly build fails, developers are warned via e-mail

@JoerivanEngelen JoerivanEngelen moved this from 🤝 Accepted to 📝Refined in iMOD Suite Jan 22, 2024
@JoerivanEngelen JoerivanEngelen moved this from 📝Refined to 🏗 In Progress in iMOD Suite Jan 25, 2024
@Manangka Manangka mentioned this issue Jan 25, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 26, 2024
@Manangka
Issue #757 Create nightly pipeline (#777)
e2dd44b 
Fixes #757

# Description
This commit adds a nightly pipeline.
The goal of the nightly pipeline is to build or repository against the
latest development branch of MODFLOW.
This will allow us to catch breaking changes early on.

The pipeline file has been refactored to prevent code duplication. This
has been accomplished by using templates.
The new nightly pipeline is added as a new subproject of the main
project

# Checklist
<!---
Before requesting review, please go through this checklist:
-->

- [x] Links to correct issue
- [ ] Update changelog, if changes affect users
- [ ] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [ ] Unit tests were added
- [ ] **If feature added**: Added/extended example
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in iMOD Suite Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manangka Manangka

Labels
discussion Discussion about design or other decisions
Projects
iMOD Suite
Status: ✅ Done
Milestone
Epic: Build improvements
Development

Successfully merging a pull request may close this issue.

Issue #757 Create nightly pipeline Deltares/imod-python
3 participants
@JoerivanEngelen @luitjansl @Manangka