Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix 1d transport test #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
luitjansl opened this issue Feb 6, 2024 · 1 comment
Closed

fix 1d transport test #823

luitjansl opened this issue Feb 6, 2024 · 1 comment
Assignees
@luitjansl
Milestone
Multi-solute tran...

Comments

@luitjansl
Copy link
Contributor

There was a typo in the comparison statement for split and unsplit model concentrations:
np.testing.assert_allclose( head.sel(time=2000)["head"].values, original_head.sel(time=200).values, ... )

both times should be 2000, not 2000 and 200.
This typo lead to unreasonably high tolerance settings to make the test pass.
@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite Feb 6, 2024
@luitjansl luitjansl self-assigned this Feb 6, 2024
@luitjansl luitjansl moved this from 📯 New to 🏗 In Progress in iMOD Suite Feb 6, 2024
@luitjansl luitjansl mentioned this issue Feb 6, 2024
Merged
5 tasks
@luitjansl luitjansl moved this from 🏗 In Progress to 🧐 In Review in iMOD Suite Feb 6, 2024
JoerivanEngelen pushed a commit that referenced this issue Feb 6, 2024
@luitjansl
Issue #823 fixing test for transport modelsplitting (#824)
366bfea 
Fixes #823 

# Description
Fixes a typo in the 1d transport model splitting test. Now that it's
fixed tolerances for the comparison could be made much stricter

# Checklist

- [X] Links to correct issue
- [ ] Update changelog, if changes affect users
- [X] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [ ] Unit tests were added
- [ ] **If feature added**: Added/extended example
@JoerivanEngelen
Copy link
Contributor

Fixed in #824

@github-project-automation github-project-automation bot moved this from 🧐 In Review to ✅ Done in iMOD Suite Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luitjansl luitjansl

Labels
None yet
Projects
iMOD Suite
Status: ✅ Done
Milestone
Multi-solute transport model support
Development

No branches or pull requests
2 participants
@JoerivanEngelen @luitjansl