Issue #961 flow packages from imod5 #1023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckages_from_imod5 # Conflicts: # imod/tests/fixtures/backward_compatibility_fixture.py
JoerivanEngelen
requested changes
May 8, 2024
imod/mf6/sto.py
Outdated
| """ | ||
|
|
||
| data = { | ||
| "specific_storage": imod5_data["sto"]["storage_coefficient"], |
There was a problem hiding this comment.
I see I erroneously mentioned to you that iMOD5 always used the specific storage, the exact opposite is true: It is always storage coefficient. This is also mentioned in the iMOD5 manual:
Storage coefficient for each model layer, i.e. the specific storage coefficient multiplied with the thickness of the model layer, for the first unconfined model layer, enter the specific storage coefficient instead, e.g.
0.15.
There was a problem hiding this comment.
ok, I'll switch it to storageCoefficient
JoerivanEngelen
approved these changes
May 8, 2024
review comment Co-authored-by: Joeri van Engelen <[email protected]>
review comment Co-authored-by: Joeri van Engelen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #961
Description
implements importing from a imod5 project file for storage and initial conditions.
Checklist
Issue #nr, e.g.Issue #737