Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Issue #1392 better default settings #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

JoerivanEngelen
Copy link
Contributor

Fixes #1392

Description

Changes default to better match iMOD5.

  • Reverted the default of SimulationAllocationOptions.riv back to what it was in the previous version, as this matches iMOD5's default setting.
  • Set SimulationAllocationOptions.drn to ALLOCATION_OPTION.at_elevation, to match iMOD5's default setting.

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example

Copy link

@JoerivanEngelen JoerivanEngelen added this pull request to the merge queue Jan 28, 2025
Merged via the queue into master with commit e2d4259 Jan 28, 2025
7 checks passed
@JoerivanEngelen JoerivanEngelen deleted the issue_#1392_better_setting_defaults branch January 28, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choose better default allocation and conductance distribution settings
2 participants