Add python 3.13 support #1404
Merged
Add python 3.13 support #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoerivanEngelen
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Thanks for the fix! Could you update this in the changelog as well?
"Fixed an ImportError which was thrown upon calling import imod with Python 3.13"
I think we are still waiting for this one to succeed: conda-forge/numba-feedstock#152 so we can really state that we are supporting Python 3.13. We can then update the documentation (see: "Which python?" section of installation guide).
Approving in advance
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1317 and #1331
Description
With
Numbanow also supporting python 3.13 we can also add 3.13 support to iMOD-python.This PR adds a 3.13 environment to the pixi.toml and also adds an import test of it to the TC pipelines.
One line of code had to be rwritten to be 3.13 compatible. The
importlib.resources.filesno longer provides a context manager and has to wrapped using theimportlib.resources.as_filemethodChecklist
Issue #nr, e.g.Issue #737