Issue #1465 Move mask to common utilities
#1466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… statements, as these checks are already done in the utility functions
Manangka
approved these changes
Feb 27, 2025
| @@ -575,8 +575,11 @@ def mask(self, mask: GridDataArray) -> Any: | |||
| masked: Package | |||
| The package with part masked. | |||
| """ | |||
|
|
|||
| return mask_package(self, mask) | |||
| result = cast(IPackage, deepcopy(self)) | |||
There was a problem hiding this comment.
I otherwise get this error message:
imod\mf6\package.py:580: error: Incompatible types in assignment (expression has type "IPackage", variable has type "Package")
There was a problem hiding this comment.
I tried fixing it, but gave up after an hour, in my search found this interesting post which could clean up interfaces a bit https://levelup.gitconnected.com/python-interfaces-choose-protocols-over-abc-3982e112342e but using Protocols didn't resolve the problem.
| remove_expanded_auxiliary_variables_from_dataset(result) | ||
| result = mask_package(result, mask) | ||
| expand_transient_auxiliary_variables(result) | ||
| return result |
There was a problem hiding this comment.
What is the return type? IPackage? Package? The type hint is any. We can be more specific
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1465
Description
maskutilities to common utilities.Package.maskand refactor itimod.mf6.utilities.dataset.pytoimod.common.utilities.value_filters.pyChecklist
Issue #nr, e.g.Issue #737