Issue #442 clipping msw pkg #1476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manangka
approved these changes
Mar 6, 2025
imod/common/utilities/clip.py
Outdated
|
|
||
| # If the first time matches exactly, xarray will have done thing we | ||
| # wanted and our work with the time dimension is finished. | ||
| if (time_start is not None) and (time_start != first_time): |
There was a problem hiding this comment.
You can reverse this if statement to return immediately. This avoid having to need a nested if statement. It also makes it clear that the part in the if statement is additional work
if (time_start is None) or (time_start == first_time):
# xarray has done the what we wanted
return
# More work is needed
...
| x_max=x_max, | ||
| y_min=y_min, | ||
| y_max=y_max, | ||
| ) |
There was a problem hiding this comment.
I like how you cleaned up this method. Really easy to read!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #442 and #542
Description
@HendrikKok asked me to clip a model for him to send it to Wageningen and I thought this would be a trivial exercise, only I realized we still lacked MetaSWAP clipping support. I noticed this was low-hanging fruit, so instead of writing some special one-off script, I thought I might as well add it to iMOD Python immediately.
This PR:
imod.mf6.Package.clip_boxtoimod.common.utilities.clipmodule.test_common/test_utilitiestest_common.pytotest_prepare/test_common.pyChecklist
Issue #nr, e.g.Issue #737