Issue #1492 migrate from fastcore to plum #1493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type for get_grid_geometry_hash, add dispatched functions that do not have Any type
|
Manangka
approved these changes
Mar 20, 2025
| return _clip_by_grid_line_data(package, active) | ||
|
|
||
|
|
||
| # For some reason the plum dispatching finds "active: GridDataArray" ambiguous |
There was a problem hiding this comment.
Maybe raise an issue about this on the their board? Seems like something that should be supported
There was a problem hiding this comment.
I don't have time now to further investigate this. Seems somewhat related to this beartype/plum#149.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1492
Description
Replace fastcore typedispatching with plum's dispatching.
Plum is a bit stricter, which I generally think is good. When fastcore's typedispatching didn't encounter a typedispatched fallback function for type
Any, for some reason things worked, but I'm not sure what it did. Plum is stricter so I had to explicitly had to add some fallback functions to either raise an error or do something.In detail, this PR
clip_by_gridmethod for GridDataArray into one for xr.DataArray and xu.UgridDataArray, as plum apparently thinks this ambiguous.create_exchange_packageto become DataArrayenforce_dim_orderandis_unstructuredenforce_dim_orderwithNoneobjecttoAny, to also supportNoneChecklist
Issue #nr, e.g.Issue #737