Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Issue #1539 fix well cleanup unstructured grids #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 27, 2025
Merged

Issue #1539 fix well cleanup unstructured grids #1540

merged 4 commits into from
May 27, 2025

Conversation

JoerivanEngelen
Copy link
Contributor

Fixes #1539

Description

Changes the following:

  • Fix bug where UgridDataArrays where silently converted to regular DataArrays (caused by the call to .data_vars).
  • Add unstructured grid test case to well tests where easily applicable.

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example

@JoerivanEngelen JoerivanEngelen requested a review from verkaik May 26, 2025 15:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@JoerivanEngelen JoerivanEngelen merged commit 698b434 into master May 27, 2025
7 checks passed
@JoerivanEngelen JoerivanEngelen deleted the issue_#1539_fix_well_cleanup_unstructured_grids branch May 27, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verkaik verkaik verkaik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] - Well.cleanup doesn't work with unstructured grids
2 participants
@JoerivanEngelen @verkaik