Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Issue #737 Add PR template #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Issue #737 Add PR template #758

merged 3 commits into from
Jan 22, 2024

Conversation

JoerivanEngelen
Copy link
Contributor

@JoerivanEngelen JoerivanEngelen commented Jan 19, 2024

Fixes #737

This PR adds a template for PRs. Unfortunately the template only works if it is in the default branch, (master) in our case, so I could not test it. I presume it works though, as it works for Ribasim.

Relevant docs

@JoerivanEngelen JoerivanEngelen changed the title Add PR template Issue # 737 Add PR template Jan 19, 2024
@JoerivanEngelen JoerivanEngelen changed the title Issue # 737 Add PR template Issue #737 Add PR template Jan 19, 2024
Copy link
Contributor

@luitjansl luitjansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ( 1 question)

@@ -0,0 +1,20 @@
Fixes #
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this line for? ( Fixes #)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This presumably automatically adds the issue number (see Ribasim library)

@JoerivanEngelen JoerivanEngelen added this pull request to the merge queue Jan 22, 2024
Merged via the queue into master with commit 49385c8 Jan 22, 2024
@JoerivanEngelen JoerivanEngelen deleted the 737_pr_template branch January 22, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Github template for pull requests
3 participants