Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Issue #748 Fix failing transport model examples i.c.w. the MODFLOW6 nightly build #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 24, 2024

Conversation

Manangka
Copy link
Collaborator

@Manangka Manangka commented Jan 23, 2024

Fixes #748

Description

The unit tests and examples were failing when run against the latest MODFLOW6 nightly. This is caused by a change on the MODFLOW6 side were any gwf-gwt exchanges has to have an actual existing file (even though it is emty).
The precious behaviour was that just mentioning the gwf-gwt exchanges in the nam file was enough.

This commit adds the gwfgwt package. It uses the same logic as the gwfgwf exchanges in terms of how it is written to disk.
Any common methods between the different type of exchanges has been moved to the newly created ExchangeBase class

Note
I didn't add any unit tests for the simulation class. The reason for this is twofold:

  • I moved code around, no major functional changes
  • We have to refactor they way the gwf-gwt exchanges are being created the moment we start working on the multimodel support for gwt, making any unit tests I add obsolete

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example

@Manangka Manangka marked this pull request as draft January 23, 2024 17:22
@JoerivanEngelen JoerivanEngelen changed the title Iiisue #748 Fix failing transport model examples i.c.w. the MODFLOW6 nightly build Issue #748 Fix failing transport model examples i.c.w. the MODFLOW6 nightly build Jan 24, 2024
@Manangka Manangka marked this pull request as ready for review January 24, 2024 11:04
Copy link
Contributor

@luitjansl luitjansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some comments

Copy link
Contributor

@JoerivanEngelen JoerivanEngelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Manangka Manangka added this pull request to the merge queue Jan 24, 2024
Merged via the queue into master with commit fdfb9d6 Jan 24, 2024
@Manangka Manangka deleted the issue_748 branch January 24, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find cause of failing solute transport tests with latest nightly build for Modflow 6
3 participants