-
Notifications
You must be signed in to change notification settings - Fork 3
Issue #746 slice model transport #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
In your description you mentioned that you get an error when derived class of the Advection package is bein reinitialized. In your code changes i don't see where this is happening. Could you tell me where this object is being reinitialized? |
In package.py, in the function "mask", last line |
Instead of adding the ignore parameter you could also override the mask method in the Advection package. You could do the same as in the HFB package where the mask method returns a deepcopy |
done |
Fixes #746
Description
Fixes the slice_model function to slice transport models as well.
Includes changes to the Advection package. The advection scheme parameter is set by the constructors of derived types of advection. Trying to reinitialize the derived type throws an error, as its construction method doesn't expect arguments. As a pragmatic solution, the constructor methods now get a
**ignored
argument to ignore these kwargs.Issue #nr
, e.g.Issue #737