Issue #798 partition ssm packages #819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gwt_exchanges # Conflicts: # imod/mf6/multimodel/exchange_creator.py # imod/mf6/simulation.py # imod/tests/test_mf6/test_multimodel/test_mf6_modelsplitter_transport.py
…ition_ssm_packages
…ition_ssm_packages
| @@ -146,7 +146,7 @@ def from_flow_model( | |||
| aux_var_names.append(species) | |||
|
|
|||
| if len(names) == 0: | |||
| raise ValueError("flow model does not contain boundary conditions") | |||
There was a problem hiding this comment.
Is this appropriate behavior? Or required?
We can log a warning?
There was a problem hiding this comment.
before we implemented partitioning, this was a red flag. But now, we can have a partition which is not on the boundary, and it will not have flow boundaries, so it is not a red flag anymore.
Now we check if the model is being split. If it is split, then it is fine to not have flow boundary conditions in this transport domain, but when it is not split, an exception is thrown if this happens
review comment Co-authored-by: Joeri van Engelen <[email protected]>
JoerivanEngelen
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #798
When we split a simulation of both flow and transport models, the ssm package of the transport simulation is re-generated after splitting, because not every flow boundary will be present in every partition.
Issue #nr, e.g.Issue #737