Consolidate lint jobs and set human-friendly job names#1557
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
There was a problem hiding this comment.
Pull request overview
Consolidates the standalone i18n lint workflow into the main lint workflow as a separate job, and adds human-friendly name fields to jobs across CI workflows so they appear consistently in GitHub branch protection rules.
Changes:
- Merges
.github/workflows/i18n.yamlinto.github/workflows/lint.yamlas a newlint-i18njob; renames the existinglintjob tolint-js. - Switches
npm installtonpm cifor reproducible installs in the lint jobs. - Adds explicit
name:fields to jobs inci-build,ci-publish,ci-release, and_meta-buildworkflows.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/lint.yaml | Splits lint into lint-js and lint-i18n jobs, switches to npm ci, sets human-friendly names. |
| .github/workflows/i18n.yaml | Removed; functionality moved into lint.yaml. |
| .github/workflows/ci-release.yaml | Adds name: Release to the release job. |
| .github/workflows/ci-publish.yaml | Adds friendly names to read-version, call-build, and update-github-release jobs. |
| .github/workflows/ci-build.yaml | Adds friendly names to read-version and call-build jobs. |
| .github/workflows/_meta-build.yaml | Adds friendly names to build-node and build-container jobs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
137b4b1 to
ae9eac1
Compare
The job names are relevant to GitHub's branch protection rules, for enforcing build checks passing. Signed-off-by: nscuro <[email protected]>
ae9eac1 to
4e24cae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consolidates lint jobs and set human-friendly job names.
The job names are relevant to GitHub's branch protection rules, for enforcing build checks passing.
Addressed Issue
N/A
Additional Details
N/A
Checklist
This PR introduces new or alters existing behavior, and I have updated the documentation accordingly