composer: bump to PHPUnit 4.6 #128
Conversation
|
👌 |
| @@ -9,7 +9,7 @@ | |||
| ], | |||
| "minimum-stability": "stable", | |||
| "require-dev": { | |||
| "phpunit/phpunit": "3.7.*", | |||
| "phpunit/phpunit": "4.6.*", | |||
There was a problem hiding this comment.
Why don't use semantic versioning and change it to: "~4.6" instead?
There was a problem hiding this comment.
To keep previous intention. Shall I then?
There was a problem hiding this comment.
This won't install atm anyway. There's no stable 4.6.x release yet.
There was a problem hiding this comment.
Also, looking at travis for this build, it used 3.7 anyway?
There was a problem hiding this comment.
@GrahamCampbell My bad, 4.5 is correct. Will fix after reply.
For the second, Travis uses own internal PHPUnit. This is probably for local use.
There was a problem hiding this comment.
You can still use the one from the composer if it's there. It'll be updated more frequently than travis', and it would make sense to use the same version on local machines as on the ci.
There was a problem hiding this comment.
I prefer not to bother composer with PHPUnit, similar to composer self-update.
There was a problem hiding this comment.
I prefer not to bother composer with PHPUnit, similar to composer self-update.
That;s not the same though. You're installing phpunit with composer on travis, then not using it?
There was a problem hiding this comment.
I have both locally, like Travis does. This is OT for this PR though. Step by step.
|
Ping @domnikl What need to be done to merge this? |
|
@TomasVotruba sorry, I could've merged it long ago :) |
composer: bump to PHPUnit 4.6
|
Oh, thanks :) |
No description provided.