chore: fix linter and ts warnings #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cursor Agent can help with this pull request. Just |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
devcycle-mcp-server | 25f766a | Aug 14 2025, 06:27 PM |
kaushalkapasi
approved these changes
Aug 13, 2025
JamieSinn
approved these changes
Aug 14, 2025
Co-authored-by: jonathan <[email protected]>
Co-authored-by: jonathan <[email protected]>
Co-authored-by: jonathan <[email protected]>
Co-authored-by: jonathan <[email protected]>
Co-authored-by: jonathan <[email protected]>
Co-authored-by: jonathan <[email protected]>
6fcec27 to
25f766a
Compare
src/ui/targetingTree.ts
Outdated
| appVersion: 'App Version', | ||
| deviceModel: 'Device Model', | ||
| customData: 'Custom Data', | ||
| audienceMatch: 'Audience Match', |
Contributor
There was a problem hiding this comment.
this shouldn't be a subtype since its a type attribute
- Remove country, appVersion, deviceModel, customData, audienceMatch, deviceType from subTypeMap - These are filter types, not subtypes - they don't belong in the subTypeMap - Add fallback handling for unmapped subtypes using type assertion - Addresses reviewer feedback: subTypeMap should only contain actual subtypes Fixes the logical error where filter types were incorrectly mixed with subtypes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all TypeScript compilation errors and significantly reduces ESLint warnings by updating oclif API usage, resolving import paths, and removing unused code.