fix bug on cookie using https #752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis barbaron <[email protected]>
koral--
approved these changes
Jan 24, 2024
Member
|
LGTM, CI build failed due to:
It looks like some intermittent issue with SSL certificates on ubuntu mirrors. I'll retrigger it later today. |
michal-murin
pushed a commit
to wandera/devicefarmer-stf
that referenced
this pull request
Jan 28, 2025
Signed-off-by: Denis barbaron <[email protected]>
michal-murin
pushed a commit
to wandera/devicefarmer-stf
that referenced
this pull request
Jan 28, 2025
Signed-off-by: Denis barbaron <[email protected]>
michal-murin
pushed a commit
to wandera/devicefarmer-stf
that referenced
this pull request
Feb 5, 2025
Signed-off-by: Denis barbaron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using STF in HTTPS mode, cookies marked "httpOnly" cannot be deleted by the client-side STF web application, resulting in incorrect session closure at logout stage, this PR allows so this delete NOW.