forked from openstf/stf
-
Notifications
You must be signed in to change notification settings - Fork 581
Add maintenance banner on UI #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
koral--
merged 7 commits into
DeviceFarmer:master
from
denis99999:add-maintenance-banner-on-ui
Jul 19, 2024
Merged
Add maintenance banner on UI #797
koral--
merged 7 commits into
DeviceFarmer:master
from
denis99999:add-maintenance-banner-on-ui
Jul 19, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis barbaron <[email protected]>
Signed-off-by: Denis barbaron <[email protected]>
Signed-off-by: Denis barbaron <[email protected]>
koral--
reviewed
Jul 18, 2024
res/app/menu/menu.css
Outdated
| white-space: nowrap; | ||
| position: relative; | ||
| top: 50%; | ||
| //left: 50%; |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be either uncommented or removed.
| , defaultValue: $scope.defaultAlertMessage | ||
| }) | ||
|
|
||
| //$scope.alertMessage = $scope.defaultAlertMessage |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| //$scope.alertMessage = $scope.defaultAlertMessage |
Signed-off-by: Denis barbaron <[email protected]>
koral--
approved these changes
Jul 19, 2024
michal-murin
pushed a commit
to wandera/devicefarmer-stf
that referenced
this pull request
Jan 28, 2025
* fix bug on email separator Signed-off-by: Denis barbaron <[email protected]> * allow group name change Signed-off-by: Denis barbaron <[email protected]> * add maintenance banner on UI Signed-off-by: Denis barbaron <[email protected]> * removes unnecessary comments Signed-off-by: Denis barbaron <[email protected]> --------- Signed-off-by: Denis barbaron <[email protected]>
michal-murin
pushed a commit
to wandera/devicefarmer-stf
that referenced
this pull request
Jan 28, 2025
* fix bug on email separator Signed-off-by: Denis barbaron <[email protected]> * allow group name change Signed-off-by: Denis barbaron <[email protected]> * add maintenance banner on UI Signed-off-by: Denis barbaron <[email protected]> * removes unnecessary comments Signed-off-by: Denis barbaron <[email protected]> --------- Signed-off-by: Denis barbaron <[email protected]>
michal-murin
pushed a commit
to wandera/devicefarmer-stf
that referenced
this pull request
Feb 5, 2025
* fix bug on email separator Signed-off-by: Denis barbaron <[email protected]> * allow group name change Signed-off-by: Denis barbaron <[email protected]> * add maintenance banner on UI Signed-off-by: Denis barbaron <[email protected]> * removes unnecessary comments Signed-off-by: Denis barbaron <[email protected]> --------- Signed-off-by: Denis barbaron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a maintenance banner to alert users of important events, it is controlled by the administrator in the "settings->general" tab, he can activate/deactivate the banner and there are three levels of alerts ( Information, Warning, Critical) with three different associated colors, with of course the text to display with a horizontally scrolling effect.
Corresponding APIs have also been added.