Conversation
gfrn
self-requested a review
June 19, 2024 14:28
gfrn
approved these changes
Jun 19, 2024
gfrn
approved these changes
Jun 26, 2024
…-population-of-source-fields
ndg63276
deleted the
improvement/LIMS-1257/allow-population-of-source-fields
branch
July 9, 2024 13:20
ndg63276
added a commit
that referenced
this pull request
Jul 23, 2024
* LIMS-1319: Show dose for all data collection types (#791) * LIMS-954: Add ability to edit manufacturer serial no on dewars (#652) * LIMS-1276: Add printed date to shipping labels (#755) * LIMS-902: Clear sessionId from containers when requesting a dewar transfer (#673) * LIMS-277: Fix sample changer view scaling (#794) * LIMS-121: Allow use of VMXm Gridboxes and Cartridges (#732) * LIMS-1257: Allow population of source fields (#769) * LIMS-1382: Add message to users about using the shipping service (#801) --------- Co-authored-by: Mark Williams <[email protected]> Co-authored-by: Guilherme Francisco <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1257
Summary:
Karl has added a source column to the BLSample, Container, Dewar and Shipping tables. By default it gets populated with the user name of the current database user, but we should allow something more descriptive in there, for eg IceBear, future web-based CSV uploader etc
Changes:
To test:
ispyb_web@%orsynchweb_dev@%(actual username depends on your dev setup)SOURCEparameter each time, check this goes into the database. Dewars created at the same time as the shipment will have the same source.