Add super-state-machine as direct dependency #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously available as a transitive dependency from bluesky but has now been removed (bluesky/bluesky#1708). This is a temporary workaround to make the build work again and may be reverted if the types are made available from bluesky in future. See #553.
callumforrester
approved these changes
Jul 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 41 41
Lines 1880 1880
=======================================
Hits 1717 1717
Misses 163 163 ☔ View full report in Codecov by Sentry. |
|
I think this is the right thing to do, I think we also need to raise an issue with This is only used for type annotations, i.e. the thing returned by |
DiamondJoseph
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously available as a transitive dependency from bluesky but has now been removed (bluesky/bluesky#1708).
This is a temporary workaround to make the build work again and may be reverted if the types are made available from bluesky in future.
See #553.