make rnn.fsx example device agnostic. #428
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
reviewed
Oct 11, 2022
| @@ -50,13 +50,14 @@ let modelFileName = "rnn_language_model.params" | |||
| if File.Exists(modelFileName) then | |||
| printfn "Resuming training from existing model params found: %A" modelFileName | |||
| languageModel.state <- dsharp.load(modelFileName) | |||
| languageModel.move(Device.Default) | |||
There was a problem hiding this comment.
Shouldn't the load happen on the default device in any case? Is this a problem with dsharp.load?
There was a problem hiding this comment.
Yes, I think dsharp.load loading into the default device makes sense, and that's what seems to be the goal of PR #430.
Pytorch is a little different, it would torch.load into whatever device the tensor was saved from: "They are first deserialized on the CPU and are then moved to the device they were saved from" (link).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor changes that will allow rnn.fsx to run if the dsharp.config is changed to GPU.
Thanks for your incredible work this past month to incorporate my change requests into the dev branch! I'm looking forward to using the new version once it's released on the nuget feed.