Change Panda3D version#15
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CI build workflow to build against the latest Panda3D source by default and simplifies the Python package initialization by removing platform-specific shared-library search path handling.
Changes:
- Update GitHub Actions workflow default Panda3D ref from
release/1.10.xtomaster. - Install
panda3d-interrogateduring the CI build to ensure interrogate tooling is available. - Remove platform-specific DLL/shared-library path setup logic from
source/__init__.py.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
source/__init__.py |
Removes runtime shared-library search path adjustments; now only re-exports the native extension symbols. |
.github/workflows/build.yml |
Switches default Panda3D ref to master and adds a step to install panda3d-interrogate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the build workflow to use the latest Panda3D source by default and simplifies the
source/__init__.pyinitialization logic by removing platform-specific shared library path handling. Additionally, it ensures that thepanda3d-interrogatedependency is installed during the build process.Build workflow updates:
release/1.10.xtomasterin both the workflow input and thePANDA3D_REFenvironment variable, ensuring builds use the latest Panda3D source by default.panda3d-interrogatepackage in the GitHub Actions build workflow, ensuring required tools are available.Codebase simplification:
source/__init__.py, relying instead on standard import mechanisms and simplifying the initialization code.source/__init__.pyby deleting now-unnecessary imports and variables related to the removed path handling logic.