fix #252 and #302 after vscode update to 1.5.1 #305
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #252 and #302 after vscode update to 1.5.1
Remote debugging broke again after VSCode updated to 1.5.1.
Reading your first fix to #252, I understood that part of code better, I think. And I still believe that using platform specific version of
path
to tackle with remote paths should solve the problems, e.g.path.sep
,path.resolve
, etc. Ref: https://nodejs.org/api/path.html#path_windows_vs_posixSo I changed the logic a bit, but couldn't come up with a better name than
path2
, to avoid name conflict withremotePath
, name of the argument.I also removed the call to
validatePathSync()
, not seeing its effect, since I believed oncepath
were platform specific, there should be no problems.Correct me if I'm wrong. Thanks!