Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix #252 and #302 after vscode update to 1.5.1 #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2016

Conversation

jackqq
Copy link
Contributor

@jackqq jackqq commented Sep 12, 2016

fix #252 and #302 after vscode update to 1.5.1

Remote debugging broke again after VSCode updated to 1.5.1.

Reading your first fix to #252, I understood that part of code better, I think. And I still believe that using platform specific version of path to tackle with remote paths should solve the problems, e.g. path.sep, path.resolve, etc. Ref: https://nodejs.org/api/path.html#path_windows_vs_posix

So I changed the logic a bit, but couldn't come up with a better name than path2, to avoid name conflict with remotePath, name of the argument.

I also removed the call to validatePathSync(), not seeing its effect, since I believed once path were platform specific, there should be no problems.

Correct me if I'm wrong. Thanks!

@DonJayamanne
Copy link
Owner

Makes perfect sense, thanks

@DonJayamanne DonJayamanne merged commit 39838f4 into DonJayamanne:master Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants