Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Kit: the issue path can no longer end green without a PR - #50

Merged
mcarter-astronautdev merged 2 commits into
mainfrom
fix/issue-path-never-silent
Sep 10, 2026
Merged

mcarter-astronautdev merged 2 commits into
mainfrom
fix/issue-path-never-silent

Conversation

@mcarter-astronautdev

Copy link
Copy Markdown
Member

Avara #195 (Bonsai TSK-00986) was the first issue-event run on v1.14.0: the implementer pushed a correct fix, ran six more minutes, and exited green without gh pr create. The transcript was not kept, so the cause is unproven; the best fit is anthropics/claude-code-action#1499. Rides v1.15.0.

  • templates/github/claude.yml: CLAUDE_CODE_DISABLE_BACKGROUND_TASKS=1 on the action step; show_full_output: true; the execution transcript uploaded as an artifact (30 days); a guard step on the issue path that fails the job when no open PR exists from issue-<n>, so the existing failure comment lands on the issue.
  • .github/workflows/{pr-first-review,ticketed-review,dependabot-report}.yml: the same env var on their action steps.

Comment thread templates/github/claude.yml Outdated
@macroscopeapp

macroscopeapp Bot commented Sep 10, 2026

Copy link
Copy Markdown

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR changes existing Claude automation behavior across multiple workflow paths by disabling background tasks and making issue runs fail when no pull request is opened. The diff is focused and intentional, but the shared template and propagated execution change have enough runtime and fleet-wide impact to merit human review.

You can add or adjust custom eligibility rules. Learn more.

@mcarter-astronautdev

Copy link
Copy Markdown
Member Author

Human review for the Approvability verdict: this is the fix Maria approved after the Avara #195 post-mortem. Correctness is clean, the Critical on the transcript artifact was addressed by removing the upload, and the change only takes effect in the fleet at the v1.15.0 wave. Merging.

@mcarter-astronautdev
mcarter-astronautdev merged commit 6732ba7 into main Sep 10, 2026
4 checks passed
@mcarter-astronautdev
mcarter-astronautdev deleted the fix/issue-path-never-silent branch September 10, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant