fix(Comm): improve usb EStop#102
Merged
Merged
Conversation
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull request overview
Improves Emergency Stop behavior when connected over USB (especially during blocking G-code) by introducing a dedicated E-stop path and optional use of the Duet’s second USB channel, plus related UI/settings and i18n updates.
Changes:
- Add
Comm::Duet::Estop()and route the sidebar E-stop action through it. - Add a developer setting + persisted storage key to enable/initialize the second USB channel and route specific commands to channel 1.
- Update USB connection parameters/logging and add i18n strings for E-stop reset messaging.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/UI/Widgets/SideBar/EStopPresenter.cpp | Uses Comm::DUET.Estop() and adjusts the posted response type. |
| src/UI/Screens/Settings/SettingsView.h | Adds a toggle widget for enabling the second USB channel. |
| src/UI/Screens/Settings/SettingsView.cpp | Wires the new toggle to storage and sends M575 when enabling while connected via USB. |
| src/Storage.h | Declares a new persisted key for the second USB channel setting. |
| src/Storage.cpp | Defines the new persisted key (developer:enable_second_usb_channel). |
| src/ObjectModel/PrinterStatus.cpp | Sends M999 on halted and posts a new translated “reset” info message. |
| src/Hardware/Duet.h | Declares Duet::Estop(). |
| src/Hardware/Duet.cpp | Implements Estop(), updates USB send behavior/channel routing, and initializes USB port(s) with M575. |
| src/Comm/Usb.cpp | Improves libusb open error logging and adjusts pluralization in channel logging. |
| assets/i18n/pt-PT.json | Adds estop.reset_message. |
| assets/i18n/nl-NL.json | Adds estop.reset_message. |
| assets/i18n/it-IT.json | Adds estop.reset_message. |
| assets/i18n/fr-FR.json | Adds estop.reset_message. |
| assets/i18n/es-ES.json | Adds estop.reset_message. |
| assets/i18n/en-GB.json | Adds estop.reset_message and the new settings label key. |
| assets/i18n/de-DE.json | Adds estop.reset_message. |
| CMakeLists.txt | Removes the build-time option for second USB channel support (now runtime-controlled). |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #90
USB estop during blocking gcode commands requires RRF 3.6.3 or later