Adding an invalidate time option for authenticators to require login in new browser sessions #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreyssmith2nd
approved these changes
Feb 19, 2020
Contributor
jeffreyssmith2nd
left a comment
There was a problem hiding this comment.
Looks fine to me, may want one of the React devs to check it out as well if they are able.
2 tasks
nasser85
reviewed
Feb 25, 2020
| */ | ||
| checkForInvalidatedSession = (type, invalidate) => { | ||
| if (type && invalidate && new Date(invalidate) <= new Date()) { | ||
| this.clearCache(); |
Contributor
There was a problem hiding this comment.
Should we call this.state.logout() as well?
Author
There was a problem hiding this comment.
Since the login hasn't been started and activeAuthenticator isn't set yet at this point, logout causes an error.
nasser85
approved these changes
Feb 25, 2020
Contributor
nasser85
left a comment
There was a problem hiding this comment.
Small question, but otherwise LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Users that are already authenticated are re-logged in on refresh to emulate normal user sessions on other sites. Adding an optional invalidate time option for authenticators to cause users to re-authenticate after the time has elapsed and a new browser session occurs.
Resolves EOSIO/universal-authenticator-library#48
API Changes
Documentation Additions