Minimizing the amount of authenticator initializations #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasser85
reviewed
Feb 25, 2020
| */ | ||
| showModal: () => { | ||
| const { availableAuthenticators } = this.state | ||
| availableAuthenticators.forEach(auth => auth.reset()) |
Contributor
There was a problem hiding this comment.
What's the rationale for removing this line?
Author
There was a problem hiding this comment.
auth.reset() resets the authenticators to default and then calls the init method again, which adds to the initialization calls.
Contributor
There was a problem hiding this comment.
Thanks. I see. A thing to keep in mind is the edge case where a developer would need their app to explicitly reset an active authenticator before calling showModal - otherwise the modal won't ever show up.
nasser85
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Due to multiple Authenticator initializations, the integration with Scatter was not working correctly. ual-reactjs-renderer was initializing the ual-scatter Authenticator three times, which was calling connect() multiple times to scatterjs-core. There was an issue with old websockets being closed but utilized in scatterjs (GetScatter/scatter-js#156) but that has since been resolved. Fixing the multiple initializations/connections on ual-reactjs-renderer's end here as well to avoid this issue in the future or with other Authenticators.
API Changes
Documentation Additions