Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixes bug described https://github.com/EOSIO/ual-reactjs-renderer/iss… #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixes bug described https://github.com/EOSIO/ual-reactjs-renderer/iss… #94

wants to merge 1 commit into from

Conversation

@prfigueroa
Copy link

@prfigueroa prfigueroa commented Jun 25, 2020 •
edited
Loading

Change Description

Description of issue #92 from aaroncox:

When using the ual-reactjs-renderer within an application that uses a minification build process, the names of the authenticators are getting mangled and corrupting the local storage value for UALLoggedInAuthType. The value saved in local storage ends up being the minified value (like n) and causes session persistence to break.

This is happening because it's currently using the constructor value which seems to be a valid target for mangling

A note on priority: This is blocking my adoption of UAL for the Acueos (Compound Finance protocol implementation on EOS) dApp.

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@jlamarr22
Copy link
Contributor

jlamarr22 commented Jun 26, 2020

Hi @prfigueroa -- thanks for adding this PR. Instead of using getStyle, we're going to update the UAL packages to use a new method getName. I'll report back here once that's complete, but these updates should be finished today and release as part of 0.3.0.

@jlamarr22
Copy link
Contributor

jlamarr22 commented Jun 26, 2020

@prfigueroa This was fixed as part of an enhancement to the base universal-authenticator-library. You can see these changes for this particular repo in the following PRs:

ual-reactjs-renderer v0.3.0 is now be available with these changes here: https://www.npmjs.com/package/ual-reactjs-renderer/v/0.3.0

Thanks again for logging this PR. Please let us know if you have any issues with the latest version.

@jlamarr22 jlamarr22 closed this Jun 26, 2020
@prfigueroa
Copy link
Author

prfigueroa commented Jun 27, 2020 •
edited
Loading

@jlamarr22 unfortunately, the bug is still occurring as confirmed through testing in the Acueos staging environment and the testing Aaron Cox @aaroncox did for the Anchor authenticator RC that added the getName method. Can you please reactivate the pull request or issue? Much appreciated.

Update: here is the fix #97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prfigueroa @jlamarr22