Implemented Maniacs Command 3011: ChangeBattleCommandEx #3290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
…selected (just like Maniacs). Also fixed a case where the options for auto battle were not shown despite having other options available to use by the player: Win/Lose
Ghabry
requested changes
Nov 7, 2024
Member
Ghabry
left a comment
There was a problem hiding this comment.
Thanks for the contribution. The logic of the code itself is fine. I just have style/idiom nits. You could not know them as is your first contribution.
…c/readability improvements based on Ghabry's feedback.
Member
|
Jenkins: test this please @MakoInfused I'll send you an invite for the "Player Team". When you accept it then the PR builders will run automatically... |
Ghabry
approved these changes
Nov 7, 2024
Member
Ghabry
left a comment
There was a problem hiding this comment.
The one build failure is just a timeout so LGTM 👍
fdelapena
approved these changes
Nov 7, 2024
Contributor
Author
|
Jenkins: retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the maniacs patch ChangeBaltteCommandEx with something like this:
Will now give you the expected behavior in EasyRPG:
And for the actors themselves (in my example the row command is turned off):
Developers can mix and match these features and all commands are supported. Including the "Win" and "Lose" commands.