[WideScreen] Fix the calculation of the Panorama's/Picture's offsets when using fakeResolution #3510
Conversation
|
ca660b6 Fixes the calculation of Picture's offset (the fix is similar to e073662 for Panoramas). At first it didn't solve issues in Aëdemphia for some map smaller than the screen. 
I discovered that when using FakeResolution mode, the result was wrong, ex. with a map of 20 horizontal tiles:
Turns out 80c4715 fixes this issue by removing this offset applying to the screen X/Y position when using FakeResolution mode. Interior are now fixed in Aëdemphia, here is a video of the first town of the city with this PR: |
|
FakeResolution mode seems not to center the screen on a map with looping. 
|
This PR will address problems of Panoramas/Pictures not being correctly displayed when using Custom Resolution and the FakeResolution mode.
Problems occur when displaying a map smaller than the screen. With the FakeResolution mode, the map is centered (and black bar are displayed around the screen.
But Panoramas and pictures offset are not calculated correctly, resulting in wrong positioning.
I discovered that the root cause was that the code was assuming that small maps were always of the size of 320x240, therefore maps with size larger than 320x240 but smaller than the Custom Resolution were not handled correctly.
Please do not merge yet, the issue related to Panorama should be fixed, but I discovered that we have a similar problem with Pictures.
As mentioned in #3509, Aëdemphia is a great game to test this PR.
This also fixes #3342 .