Fix stale error display in stacks view (#236)#242
Merged
Conversation
OnEnter() now triggers LoadStacksCmd to recompute error maps from fresh snapshot data when returning to stacks view via back navigation. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Collaborator
|
Checked it, works |
mosonyi
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
goBack()restores the previous model instance from the view stack, butOnEnter()returnednil— no data refresh was triggered, sostackHasError/stackErrorTextmaps retained stale valuescheckStacksCmdhashesStackEntry{Name, ServiceCount, NodeCount}which doesn't include error state, so the polling loop couldn't detect error-only changes eitherOnEnter()now returnsLoadStacksCmd(m.nodeID), which unconditionally recomputes error maps from the current snapshotTest plan
go build ./...go vet ./...go test -race -count=1 ./views/stacks/ -vgo test -race -count=1 ./...golangci-lint run ./...— 0 issues🤖 Generated with Claude Code