Refactor FilterableList: centralize header, footer, and column width#244
Merged
Conversation
…150, #151, #179) Move header rendering, footer rendering, column width computation, and frame construction into FilterableList, eliminating ~600 lines of duplicated boilerplate across all 7 views. Add nil-slice hardening for loading states and 26 unit tests for the new API. Co-Authored-By: Claude Opus 4.6 <[email protected]>
clangenb
approved these changes
Feb 19, 2026
Collaborator
clangenb
left a comment
There was a problem hiding this comment.
This is a pure technical PR. I reviewed and tested the functionality and it works.
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HeaderConfig,FooterConfig, andColumnDeftypes toFilterableListwithRenderHeader(),RenderFooter(),RenderFramedView(), andColWidths()methodsensureCursorVisible,RenderFooterempty-list guard)Closes #150, closes #151, closes #179.
Test plan
go build ./...passesgo test -race -count=1 ./...— all tests pass (including 26 new FilterableList tests)golangci-lint run ./...— 0 issues🤖 Generated with Claude Code