Add Business Edition placeholders for Shell and Port Forward#250
Merged
Conversation
) Extract common BE gating helpers (BEHelpDesc, BEUnavailableErr) and add Shell/Port Forward keybindings as BE-gated placeholder actions in the services view. Rename existing "Pro" terminology to "Business Edition". Co-Authored-By: Claude Opus 4.6 <[email protected]>
Allow the pro repo to override the BE unavailable message (e.g. to add "coming soon" language) by exporting the format string as a package-level variable. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BEHelpDesc,BEUnavailableErr) intoviews/view/edition.go([feature-gates] keep an eye on number of features and alternatively add an actions registry #225)x) and Port Forward (w) as BE-gated placeholder keybindings in services view (Add Business Edition Placeholders #237)Test plan
go test ./views/view/ ./views/services/ ./views/secrets/ ./views/helpbar/passesgo test ./...passesgolangci-lint run ./...cleanx/win services view shows BE dialog with URL when actions not registeredxin secrets view shows BE dialog with updated textCloses #237, closes #225
🤖 Generated with Claude Code