Fix 'c' key intercepting search input in stacks view#270
Merged
Conversation
Move the search mode guard above the 'c' shortcut handler so that typing 'c' while in '/' search mode appends to the filter query instead of opening the create stack dialog. Fixes #259 Co-Authored-By: Claude Opus 4.6 <[email protected]>
51aed2c to
262076d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cwhile in/search mode on the stacks view opened the create stack dialog instead of appending to the search querycshortcut handler was checked before the search mode guard inviews/stacks/update.gochandler (swap two code blocks, no logic changes)Test plan
go buildcompiles cleanlygo test ./views/stacks/...passesgo test ./...passes (all packages)golangci-lint run ./...— 0 issues/→ type a query containingc→ verify it filters instead of opening create dialog🤖 Generated with Claude Code