refactor: aggregate systeminfo messages via marker interface#281
Merged
Conversation
Replaces four identical case branches in the app-level router with a single SystemInfoMsg interface match. New systeminfo message types now route automatically without touching app/update.go. Closes #114 Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SystemInfoMsgmarker interface in the systeminfo package, implemented by all four message types (Msg,SlowStatusMsg,TickMsg,SpinnerTickMsg)app/update.gointo a single interface matchCloses #114
Test plan
go build ./...passesgo vet ./...passesgo test ./...passes (includingviews/systeminfo)🤖 Generated with Claude Code