fix: don't quit app when dismissing error dialog without fallback view#297
Merged
Conversation
The :bootstrap command will deploy swarmcli infrastructure (rbac-proxy + agent) in the Business Edition. In the free edition it shows the standard BE feature unavailable message. Co-Authored-By: Claude Opus 4.6 <[email protected]>
When an AppErrorMsg has no FallbackView set (e.g. the :bootstrap placeholder), dismissing the error dialog called goBack() which returns tea.Quit at the root view. Now it simply closes the dialog and stays on the current view. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppErrorMsgerror dialog (e.g. from:bootstrap) with noFallbackViewcalledgoBack(), which returnstea.Quitat the root view — quitting the appTest plan
go buildsucceedsgo test ./...passesgolangci-lint run ./...clean:bootstrap→ error dialog → press Enter → app stays open🤖 Generated with Claude Code