Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: forward / and : to active inputs#302

Merged
clangenb merged 1 commit into
mainfrom
fix/action-keys-in-inputs
Mar 24, 2026
Merged

fix: forward / and : to active inputs#302
clangenb merged 1 commit into
mainfrom
fix/action-keys-in-inputs

Conversation

@eldara-cruncher
Copy link
Copy Markdown
Collaborator

@eldara-cruncher eldara-cruncher commented Mar 19, 2026

Summary

  • Forward / and : as text to commandInput, searchInput, and view-internal search (ctrl+f) instead of swallowing them or triggering actions
  • Fixes 5 related bugs in app/update.go where the : and / handlers ran before the input-forwarding logic
  • Adds tests for all 5 cases

Fixes #300

Test plan

  • go test ./app/... -run "TestSlash|TestColon" — 5 new tests pass
  • go test ./... — full suite passes
  • Manual: open search with /, type / and : — characters appear
  • Manual: open command with :, type : and / — characters appear
  • Manual: in logsview ctrl+f search, type : — character appears

🤖 Generated with Claude Code

…ng them

The `:` and `/` key handlers in app/update.go ran before the
commandInput/searchInput forwarding logic, so those characters were
intercepted and swallowed when an input was active. This made it
impossible to type `/` or `:` in the search bar, command bar, or
view-internal ctrl+f search.

Fixes #300

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@eldara-cruncher eldara-cruncher force-pushed the fix/action-keys-in-inputs branch from 8f1fd7a to 609e3d9 Compare March 19, 2026 07:16
@clangenb clangenb requested a review from mosonyi March 19, 2026 07:22
Copy link
Copy Markdown
Collaborator

@mosonyi mosonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In log view, I can search now for '/'.
I don't like the idea of searching for something, then all the other logs are hidden.
Better to show everything but highlight the search text.

@clangenb
Copy link
Copy Markdown
Collaborator

In log view, I can search now for '/'. I don't like the idea of searching for something, then all the other logs are hidden. Better to show everything but highlight the search text.

You can still have the regular highlighted search with the s-key.

@mosonyi
Copy link
Copy Markdown
Collaborator

mosonyi commented Mar 19, 2026

In log view, I can search now for '/'. I don't like the idea of searching for something, then all the other logs are hidden. Better to show everything but highlight the search text.

You can still have the regular highlighted search with the s-key.

At the log view the 's' is the Autoscroll off/on

@clangenb
Copy link
Copy Markdown
Collaborator

Then check for yourself, there is a key XD

@mosonyi mosonyi self-requested a review March 24, 2026 17:26
Copy link
Copy Markdown
Collaborator

@mosonyi mosonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual test: OK!

@clangenb clangenb merged commit f5b736f into main Mar 24, 2026
11 checks passed
@eldara-cruncher eldara-cruncher deleted the fix/action-keys-in-inputs branch June 5, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[logsview] fix searching for /

3 participants