fix: add timeouts to Docker API calls and reduce redundant requests#315
Merged
Conversation
Docker API calls in info.go used context.Background() with no timeout, causing indefinite hangs when Docker is behind a slow proxy (e.g. RBAC proxy in BE deployments). Additionally, the 8-second systeminfo cycle made 5+2N API calls per cycle due to duplicate NodeList and separate CPU/memory stats passes. Changes: - Add 10s timeout to all 9 Docker API calls in info.go - Add GetSwarmResourceUsage() that collects CPU+memory in a single pass (1 ContainerList + N ContainerStats instead of 2+2N) - Derive node capacity from cached snapshot in LoadStatus() instead of making 2 fresh NodeList calls - Parallelize GetContainerCount + GetServiceCount in LoadStatus() Reduces API calls per 8s cycle from 5+2N to 1+N. Ref: Eldara-Tech/swarmcli-be#53 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
11845ff to
90514fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker/info.go(previouslycontext.Background()with no timeout — hangs indefinitely through slow proxies)GetSwarmResourceUsage()that collects CPU+memory stats in a single pass (1 ContainerList + N ContainerStats) instead of two separate passes (2 ContainerList + 2N ContainerStats)LoadStatus()instead of making 2 fresh NodeList callsGetContainerCount+GetServiceCountinLoadStatus()Test plan
go test -race -count=1 ./...— all 30 packages passgo build ./...— compiles cleanRef: Eldara-Tech/swarmcli-be#53
🤖 Generated with Claude Code