chore: add goheader linter for dev-time SPDX header enforcement#332
Merged
Conversation
Enforce SPDX headers at lint time — `golangci-lint run` now catches missing headers locally, complementing the existing CI-only `scripts/check-spdx.sh` check. All existing .go files already carry the required header. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
54 .go files added to main after the original SPDX pass were missing headers. The gap went undetected because check-spdx.sh had a pipe-subshell bug: `fail=1` inside `while read` runs in a subshell (POSIX pipe semantics), so the outer `exit "$fail"` always exited 0. Fix check-spdx.sh to avoid the pipe by writing find output to a temp file and reading from it, so `fail` propagates correctly. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
c53f147 to
e4ec9f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code