ci: restore synchronize trigger on check_labels#352
Merged
Conversation
#349 dropped `synchronize` from check_labels.yml on the reasoning that "labels don't change on new commits" — semantically true, but breaks branch-protection mechanics. Required checks are evaluated per commit SHA: a successful run on the original HEAD doesn't carry forward when new commits land (whether by user push or by merging main into the PR branch). Without synchronize, the workflow never re-publishes a status on the new HEAD, leaving required checks stuck on "Expected — Waiting". Observed on #350 after a merge-from-main: SwarmCLI CI / Integration Tests / License checks all re-ran on the merge SHA, but Check labels stayed on the prior SHA. Re-add synchronize. Cost vs original justification: each synchronize fires 3 matrix jobs (~3 billed minutes). Worth it — the alternative is manually rerunning the workflow on every PR that gets synced with main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#349 dropped
synchronizefrom check_labels.yml on the reasoning that "labels don't change on new commits" — semantically true, but breaks branch-protection mechanics. Required checks are evaluated per commit SHA: a successful run on the original HEAD doesn't carry forward when new commits land (whether by user push or by merging main into the PR branch). Without synchronize, the workflow never re-publishes a status on the new HEAD, leaving required checks stuck on "Expected — Waiting".Observed on #350 after a merge-from-main: SwarmCLI CI / Integration Tests / License checks all re-ran on the merge SHA, but Check labels stayed on the prior SHA. Re-add synchronize.
Cost vs original justification: each synchronize fires 3 matrix jobs (~3 billed minutes). Worth it — the alternative is manually rerunning the workflow on every PR that gets synced with main.