ci(goreleaser): do not move :latest on prereleases#387
Merged
Conversation
The :latest docker_manifest had no skip_push guard, so every tag —
including RC prereleases — repointed eldaratech/swarmcli:latest. As a
result :latest currently tracks v1.7.0-rc2. Add skip_push: "auto" so the
:latest manifest is only pushed for stable (non-prerelease) tags,
matching the docker/metadata-action latest=auto behaviour the agent and
rbac-proxy release workflows already use. Versioned :{{.Tag}} manifests
are unaffected and still publish for RCs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
:latestdocker_manifesthad noskip_pushguard, so every tag — including RC prereleases — repointedeldaratech/swarmcli:latest. As a result:latestcurrently tracksv1.7.0-rc2(a prerelease), meaning a plaindocker pull eldaratech/swarmcligets an RC.Adds
skip_push: "auto"to the:latestmanifest so it is only pushed for stable (non-prerelease) tags — mirroring thedocker/metadata-actionlatest=autobehaviour theswarmcli-agentandswarmcli-rbac-proxyrelease workflows already rely on. The versioned:{{ .Tag }}manifest is unchanged and still publishes for RCs.The live
:latesttag will be repointed to thev1.6.0GA manifest separately (registry op).